User:Victor Grousset - tuxayo/Community work/Reports/2025-02

QA

Notes:

An attempt results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue. Or questions to clarify something in the code.
Partial QA is a way to contribute to a ticket that I can't QA alone but for which I can confidently review only part of the code or aren't sure enough about understanding the functional need and change.

Dig into warning on updatedatabase related to Bug 38664 - Tidy the whole codebase

Open ticket with possible fix: Bug 39101 - warning: "sort (...) interpreted as function" when running updatedatabase

Possible reproduction of git hook issue reported in chat related to Bug 38664 - Tidy the whole codebase

Dig into CI failures after Bug 38664 - Tidy the whole codebase

Abort due to Jonathan having fixed it super quick! :)

Maybe found issue + find remaining test failure + confirm other test fixes: Bug 38664 - Tidy the whole codebase

Find another issue and submit fix: Bug 38664 - Tidy the whole codebase

Found issue related to Bug 38664: KTD: pre-commit hook shouldn't check tidyness on DBIX schema files

https://gitlab.com/koha-community/koha-testing-docker/-/issues/478

Found issue related to Bug 38664: QA tools: tidyness check shouldn't happen on DBIX schema files

https://gitlab.com/koha-community/qa-test-tools/-/issues/91

Feedback on proposed course of action and alternative suggestion: Bug 39115 - Tidy script should list the files we do not want to tidy

In chat.

Issue found: Bug 39115 - Tidy script should list the files we do not want to tidy

Round 2: Other issue found: Bug 39115 - Tidy script should list the files we do not want to tidy

Round 3: Confirm fix works + add follow-up fix: Bug 39115 - Tidy script should list the files we do not want to tidy

QA it + find issue in follow-up added after: Bug 39096 - Add "tidy all" commits to a git blame ignore file

Find issue + submit follow-up for it: Bug 39149 - .PL files not tidy

QA follow-up: Bug 39130 - Add unit tests for xgettext.pl

Try to unblock by researching and detailing options: Bug 38345 - Remove support for OpenSearch

And shed light to the much larger issue of continuing Elasticsearch support (and more urgent than we think) which influences a lot how to fix this one. Opened ticket: Bug 39174 - Search::Elasticsearch is end of life and will at some point not be compatible anymore with future versions.

Find very minor issue: Sample data insertion: Issue #86: Update auth_header.sql for bug 26684

https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/77

QA tools: Report and submit fix: Bug 39188 - ESLint doesn't work due bug in old "globals" node package

Needed to apply coding guideline JS8: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guidelines_set_by_ESLint

Issue found and couldn't solve conflict: Bug 38331 - Add date accessioned, item lost on, damaged on, withdrawn on, and date last seen columns to itemsearch results

Note for the people funding my work and the rest of the community for transparency purposes: quick QA attempt of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

QA tools: quickly fix typos. Via online editor.

https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/77
https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/78

Found issues and add follow-ups for others: Bug 36868 - Add ability to automatically empty cart after placing holds ( staff interface and OPAC )

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

Found issues and start proofreading code: Bug 10190 - Overdue notice triggers based on item type

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from PTFS Europe.
For QA of enhancements I'm asked to ideally focus on one monthly.
This one is huge so this is taken into account to keep a balanced time with work on other tickets.

koha-testing-docker: #535 Make it easy to run `yarn install` by the instance user

https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/535

Rebase progress and find issue: Bug 23732 - Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from BibLibre.
For QA of enhancements I'm asked to ideally focus on one monthly.

That's an enhancement from BibLibre that they want a lot since years. I coauthored it when I worked there and wasn't able to finish it in volunteer time in the years after. So I'm trading QAing a BibLibre enhancement this month for directly working on this enhancement of their. And this time it's half QA, half direct work.

Signoffs (testing submitted patches so they can move on to be integrated)

Note: an attempt usually results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue.

Bug 39149 - .PL files not tidy

Bug 39130 - Add unit tests for xgettext.pl

Report issue on sandboxes: Sandboxes are sometimes created with broken CSS

https://gitlab.com/koha-community/koha-sandboxes-docker/-/issues/98
It was a regular issue at the last patch testing session. And even outside that, for signoffs and QA I'm regularly using them to compare a vanilla Koha with my local one with patches applied.

Sample data insertion: Issue #86: Update auth_header.sql for bug 26684