User:Victor Grousset - tuxayo/Community work/Reports/2024-11

From Koha Wiki
Jump to navigation Jump to search

QA

Notes:

  • An attempt results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue. Or questions to clarify something in the code.
  • Partial QA is a way to contribute to a ticket that I can't QA alone but for which I can confidently review only part of the code or aren't sure enough about understanding the functional need and change.

Found more issues: Bug 36221 - Improve styling of Standard backend create OPAC form

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from PTFS Europe. For QA of enhancements I'm asked to ideally focus on one monthly. Time imbalance this month will be balanced out.

Final rounds: Found another issue + fixed others in follow-ups: Bug 36221 - Improve styling of Standard backend create OPAC form

Note for the people funding my work and the rest of the community for transparency purposes: end of QA of an enhancement from PTFS Europe. For QA of enhancements I'm asked to ideally focus on one monthly. Time imbalance this month will be balanced out.

Confirmed issues and proposed draft of sample notice Bug 37034 - Add cronjob to alert patron with bookings ended and not been converted into a loan

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from BibLibre.
For QA of enhancements I'm asked to ideally focus on one monthly.
Pointed at by PTFS Europe but still it's a BibLibre ticket.

Continued and found multiple issues and submitted follow-up: Bug 37034 - Add cronjob to alert patron with bookings ended and not been converted into a loan

Turns out the follow-up wasn't so simple so the the line between a QA follow-up and becoming a coauthor becomes blurry.
Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from BibLibre.
For QA of enhancements I'm asked to ideally focus on one monthly.

Feedback in chat on something that was blocking them: Bug 38426 - Node.js v18 EOL around 25.05 release time

Found root cause and possible fix: koha-testing-docker: Ubuntu 24.04 image (main-noble) doesn't set user ID to the same as host

https://gitlab.com/koha-community/koha-testing-docker/-/issues/462
That mess silently broke parts of the QA script and made me miss something. Only partially counted time though.

QA tooling: Rebases and made a requested follow-up on ESLint enablement patches

The cleanup they contain is also now needed for a Node.js upgrade.

  • Bug 38149 - Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
  • Bug 38167 - ESLint: migrate config to flat format + cleanup some node dependencies

Partial QA on a specific point: Bug 36836 - Review ERM module for translation issues

Checked that single quotes aren't an issue in vue templates and code sections. Actually it was for something I missed in Bug 36221 but it turned out useful for this one also. And an upcoming meeting covering single quotes and i18n for coding guidelines.

Opened ticket for missed issue in previously QAed Bug 38523 - Simple quote in ILL standard form JS can break translations

Maybe found that a dependency is not necessary: Bug 38503 - Add a Cypress task to generate objects based on its swagger def spec

Note for the people funding my work: Enhancement from Jonathan, so by transitivity a part of the 3 usual companies. And actually it's more than an enhancement. Part of the test suite is stuck on an old version of Selenium so this is a way out of Bug 29285 - UI tests: Selenium 4 support or setup Cypress to make them rewritable with it.

Quick look at this which doesn't apply: Bug 38079 - Add ability to choose sorting for holdings table

Note for the people funding my work and the rest of the community for transparency purposes: brief QA attempt and troubleshoot attempt of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

Found issues: Bug 37989 - Add template toolkit to problem_report notice

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

Found issues + sent follow-up: Bug 35635 - Expand Patron attribute type mandatory field

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

QA tooling: Quick additional testing + write test plan: Bug 38524 - Add support for Vue.js and TypeScript to ESLint config to be able to actually enforce coding guideline JS8

Patch actually implement the previous month. Submitted now.

Retested and confirmed issues previously found: Bug 28974 - Add pagination to holds queue viewer

Note for the people funding my work and the rest of the community for transparency purposes: QA (attempt) of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

Previous issue still there + found minors issue: Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.
After a review of the last months reports, I think the time worked on enhancements is comparable between the companies funding my work.
And I have a month in advance regarding the "ideally focus on one monthly". So I will balance out next month. Which fits well to focus on fixes after a release.

Found issue Bug 38411 - When adding multiple items on receive, mandatory fields are not checked

Tried to signoff but looked at the code before.

Coding guidelines wiki page: Fixed syntax errors that corrupted some code examples

Signoffs (testing submitted patches so they can move on to be integrated)

Note: an attempt usually results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue.

Bug 38268 - Callers of confirmModal need to remove the modal as the first step in their callback function

Attempt: Bug 38423 - EDIFACT invoice files should skip orders that cannot be receipted rather than failing to complete

Some security bug 1

Some security bug 2

Some security bug 3

Some security bug 4

Plus confirmed QA issue.

New tickets opened

i.e. Found something wrong and documented how to reproduce it. Or suggest an enhancement (usually for dev tools)

Bug 38588 - Checkin that triggers a transfer => print slip => Internal server error

Found when trying to review another ticket. Time only partially counted as part of QA/SO.