User:Victor Grousset - tuxayo/Community work/Reports/2024-10

From Koha Wiki
Jump to navigation Jump to search

QA

Notes:

  • An attempt results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue. Or questions to clarify something in the code.
  • Partial QA is a way to contribute to a ticket that I can't QA alone but for which I can confidently review only part of the code or aren't sure enough about understanding the functional need and change.

Some security bug 1: research on good practices on an ambiguous topic blocking the ticket

Propose a way out forward for this hard to reproduce issue Bug 38072 - Regression with modalPrint

Some security bug 2: research and test some assumptions an ambiguous topic blocking the ticket

QA tooling: Open, implement, add follow-up after feedback: Bug 38149 - Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default

Because we can't really check the JS8 guideline. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guidelines_set_by_ESLint

Research to validate the idea and mention an alternative Bug 36682 - Replace yarn with pnpm

QA tooling: Open and implement: Bug 38167 - ESLint: migrate config to flat format + cleanup some node dependencies

Another step to be able to check JS8 guideline.

QA tooling: Implement: Bug 38524 - Add support for Vue.js and TypeScript to ESLint config to be able to actually enforce coding guideline JS8

Patch submitted and ticket opened the next month.

Found issue, submitted fix, tried to weight the two possible approaches: Bug 38164 - Translation process in stable releases is broken

Open ticket for issue in QA tooling: Bug 38170 - xt/verify-yarnlock.t doesn't detect removal of packages

While reviewing the previous ticket.

Quickly validated this after a needed resignoff came: Bug 36118 - ILL request log does not display patron information

Checked there are not changes that would invalidate my previous QA.

Found minor issue, finished last code review steps, did manual testing: Bug 35287 - Add additional fields support to ERM Licenses

Note for the people funding my work and the rest of the community for transparency purposes: partial QA of a large enhancement from PTFS Europe.
For QA of enhancements I'm asked to ideally focus on one monthly.

Maybe found issue, found minor issue, fixed minor issue Bug 37722 - Add Koha Objects for Koha Holidays

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.

See also 1st item in "Misc tasks and work on tickets" section

https://wiki.koha-community.org/w/index.php?title=User:Victor_Grousset_-_tuxayo/Community_work/Reports/2024-10&action=submit#Rebase_and_fixes_for:_Bug_23732_-_Hold_rules_checker:_show_matched_rules_and_syspref_values_to_help_understand_why_a_hold_is_possible_or_not

Found issue: Bug 36221 - Improve styling of Standard backend create OPAC form

Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from PTFS Europe.
For QA of enhancements I'm asked to ideally focus on one monthly. This one will be balanced out in the next months.

Signoffs (testing submitted patches so they can move on to be integrated)

Note: an attempt usually results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue.

Bug 30888 - Add a table for deletedauthorities

Not in the scope of fundable work so time was only partially counted.

Another attempt: Bug 37650 - Checkin does not create transfers for future holds

Bug 38164 - Translation process in stable releases is broken

Reproduce failure that might be close to what happens in the CI: Bug 38236 - selenium/administration_tasks.t is failing randomly with "no such alert"

It's not QA but it's a problem with tests which are QA tools that are basically automation of a few signoffs to continuously watch for regressions.
It's not a signoff but it's trying to reproduce an issue following a test plan which is the 1st part of most test plans.
So it feels it should be somewhere.
Initially, the RM asked for help and Jonathan had yet another randomly failing test not reproducing locally :(

Quick start of planification of patch testing session with the French user group

Misc tasks and work on tickets: Analysis or implementation

Rebase and fixes for: Bug 23732 - Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not

That's an enhancement from BibLibre that they want a lot since years. I coauthored it when I worked there and wasn't able to finish it in volunteer time in the years after. So I'm trading QAing a BibLibre enhancement this month for directly working on this enhancement of their.

New tickets opened

i.e. Found something wrong and documented how to reproduce it. Or suggest an enhancement (usually for dev tools)

koha-testing-docker: Ubuntu 24.04 image (main-noble) doesn't set user ID to the same as host

https://gitlab.com/koha-community/koha-testing-docker/-/issues/462

Bug 38283 - Patron search modal has a button opened by a <button> and closed by a </a>