User:Victor Grousset - tuxayo/Community work/Reports/2024-03
QA
Notes:
- An attempt results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue. Or questions to clarify something in the code.
- Partial QA is a way to contribute to a ticket that I can't QA alone but for which I can confidently review only part of the code or aren't sure enough about understanding the functional need and change.
Bug 35773 - Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
Bug 35924 - The 'checkin slip' button should not be available for patrons whose privacy is set to never
Found issues + moved tests to separate commit Bug 36049 - Rounding prices sometimes leads to incorrect results
Bug 36076 - paycollect.tt is missing permission checks for manual credit and invoice
Found issue + moved tests to separate commit: Bug 36066 - REST API: We should only allow deleting cancelled order lines
Attempt: Bug 36130 - ILL batches table not showing all batches
Round 2 (successful!) Bug 36066 - REST API: We should only allow deleting cancelled order lines
Bug 33268 - Overlay rules don't work correctly when source is set to *
Bug 34575 - Patron search results: Add a CSS class to patron email to ease customization
Note for the people funding my work and the rest of the community for transparency purposes: QA of an very small enhancement from PTFS Europe.
For QA of enhancements I'm asked to attempt to focus on these.
Found issue: Bug 36196 - Handling NULL data in ajax calls for cities
Found issue: Bug 36118 - ILL request log does not display patron information
Found issue & rebased: Bug 36233 - Cannot search invoices if too many vendors
Found issue: Bug 34643 - Split CircConfirmItemParts for self-checkout and self-checkin
Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from ByWater Solutions.
For QA of enhancements I'm asked to ideally focus on one monthly.
Round 2: Bug 36233 - Cannot search invoices if too many vendors
Round 2: Bug 36118 - ILL request log does not display patron information
Partial (2nd signoff + debugging to help settling a point blocking the ticket) :Bug 35921 - Improve perfs of acqui-home.pl when there are many budgets
Note for the people funding my work and the rest of the community for transparency purposes: Partial QA of an enhancement from BibLibre.
For QA of enhancements I'm asked to ideally focus on one monthly.
Found issue: Bug 35659 - OAI Harvester
Note for the people funding my work and the rest of the community for transparency purposes: Partial QA (2nd signoff attempt) of an enhancement from BibLibre.
For QA of enhancements I'm asked to ideally focus on one monthly.
Bug 35616 - Add a 'source' field to Koha::Tickets to denote the path taken to report the ticket
Note for the people funding my work and the rest of the community for transparency purposes: QA of an enhancement from PTFS Europe.
For QA of enhancements I'm asked to ideally focus on one monthly.
Round 2: Found issues + added minor follow-up fix: Bug 34643 - Split CircConfirmItemParts for self-checkout and self-checkin
Bug 34663 - Errors in UNIMARC default framework
WIP (blocked by another bug) Round 3: Bug 34643 - Split CircConfirmItemParts for self-checkout and self-checkin
Found issue: Bug 36060 - If issues table includes overdues Renew selected items button is disabled
Round 2: Bug 35610 - Missing FK on old_reserves.branchcode?
Maybe found issue: Bug 36418 - Set response's content-type to application/json when needed - svc scripts
Found minor workflow issues: Bug 36111 - 856$h should not appear as a link in detailed record
Found idea to fix a bug introduced by a previously QAed patch: Bug 36425 - koha-run-backups deletes old backup files based on number of hours since modification - not date of modification
Bug 36187 - Cannot set suggestedby when adding/editing a suggestion from the staff interface
Confirmed issues, maybe found more, tested follow-up, added another follow-up: Bug 36418 - Set response's content-type to application/json when needed - svc scripts
When reviewing previous ticket, opened new ticket for left over issues : Bug 36468 - Remaining content-type = text/plain when JSON or HTML is returned
Found another minor workflow issue: Bug 36111 - 856$h should not appear as a link in detailed record
Round 2: found another issue: Bug 36060 - If issues table includes overdues Renew selected items button is disabled
Signoffs (testing submitted patches so they can move on to be integrated)
Note: an attempt usually results in feedback provided on the bug. To ask if I correctly followed the test plan due to results that I couldn't interpret. Or if there is indeed an issue.
Bug 29509 - GET /patrons* routes permissions excessive
Checked that issue with tests is fixed: Bug 32565 - Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
Round 2, now that there is a test plan :) Bug 33268 - Overlay rules don't work correctly when source is set to *
Opened new ticket that was caused by a recent big change (Bug 34478 - Full CSRF protection) : Bug 36280 - Viewing batch of staged records broken: CSRF token error
All while testing another patch.
Bug 33898 - background_jobs_worker.pl may leave defunct children processes for extended periods of time
Tested alternate patch: Bug 33898 - background_jobs_worker.pl may leave defunct children processes for extended periods of time
Bug 36232 - Error fixing OAI-PMH:AutoUpdateSetsEmbedItemData syspref name on the DB
Attempt 2/Partial: Bug 32707 - ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
1st half of test plan successful.
Maybe found issue: Bug 36349 - Login for SCO/SCI broken by CSRF
Attempt 3: Found issue: Bug 32707 - ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
Attempt 4: Success + minor test plan amend + minor QA feedback: Bug 32707 - ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields)
Bug 36432 - Remove circular dependency from Koha::Object
Misc tasks and work on tickets: Analysis or implementation
Submit patches to update our 8 container images of OpenSearch and Elasticsearch
One of the 8 patches: https://gitlab.com/koha-community/docker/koha-elasticsearch-icu/-/merge_requests/19
New tickets opened
i.e. Found something wrong and documented how to reproduce it. Or suggest an enhancement (usually for dev tools)
Reported again: Sandboxes have Koha code outdated
https://gitlab.com/koha-community/koha-sandboxes-docker/-/issues/91
koha-testing-docker: Are docker-compose.es7.yml, docker-compose.es8.yml, etc still usefull? bin/ktd doesn't use them
https://gitlab.com/koha-community/koha-testing-docker/-/issues/418
master-buster (at least) image is missing HTTP::Tiny
https://gitlab.com/koha-community/koha-testing-docker/-/issues/417