User:Victor Grousset - tuxayo/Coding Guidelines-SQL11-changes

From Koha Wiki
Jump to navigation Jump to search

Proposed change

current guideline:

WIP see if there is something to change and what.

  • Coding Guidelines
  • QA tools?
  • Existing comments?



Current state

Field comments

  • 12 occurrences of «COMMENT '»
  • More than 1000 occurrences of «, --». After a check, more than 99% are field comments so it's not noise/false positive
SchemaSpy compatibility


DBIC compatibility

Only the COMMENT syntax ends up in DBIC files

check: COMMENT syntax

check: , -- syntax

Table comments

  • 68 occurrences of «( --»
  • 2 occurrences of «COMMENT=»
SchemaSpy compatibility

Only the COMMENT= syntax

DBIC compatibility

Only the COMMENT= syntax