Development IRC meeting 16 February 2016

From Koha Wiki
Jump to navigation Jump to search


The #koha IRC channel (IRC server

If you don't have an IRC client you can join the meeting using your web browser.



  • Introductions (please use "#info" in front of your introduction to have it show up in the automatic minutes)
  • Review coding guidelines
    • New coding guidelines
      • [marcelr] In relation to Plack: Should we add a PERL rule that prohibits defining lexical variables (my $var) in MODULES at the outermost block (file level), and also prohibits directly accessing file level lexicals in subroutines of SCRIPTS.
        Suggested wording: Forbid global state variables in modules and CGI scripts, and discourage their use elsewhere. (see for context)
      • Handling disagreements
        Action from last meeting: pianohacker to suggest a possible guideline wording (
      • [khall] All methods should take a single argument, bit it an object, an id, or a hashref. This makes future modification of parameters for subroutines far simpler and less error prone, and reduces the changes needed.
      • [khall] I think we need something about limiting the use of the html filter to prevent XSS attacks (post Bug 13618)
        • [Joubu] New test added to the QA script, is it enough?
    • Reword/update coding guidelines
      • [kfischer] Merge new PERL20 and PERL20.1 into PERL15
      • [khall] Update JS4 based on the availability of the format method (from Bug 15662)
      • [kfischer] 'PERL7: Definitions' - point to Terminology instead and note that terminology in the code should follow the default en GUI terminology?
        • [marcelr] Code changes should adhere to naming conventions published elsewhere on the wiki (Patron versus Borrower, etc.)
    • Remove/obsolete/archive coding guidelines
      • [kfischer] 'PERL12: VERSION [Deprecated as of start of 3.12 release cycle] Each module should have a $VERSION variable to preserve progressive levels of compatibility with dependent code.' A bit confusing - should remaining VERSION variables be removed?
        Action from last meeting: Verify if perlcritic complains about missing VERSION and figure out, if we want/can reconfigure it.
        • [mtompset] perlcritic does not complain about missing $VERSION until -2, but since we only perlcritic to -5, there is no need to keep this.
    • Revamp/restructure coding guidelines page
  • Any bugs that are in discussion
    • Please add links to bugs and comments here...
  • General development discussion (Trends, ideas, ...)
  • Updates from the QA team
  • Set time of next meeting


  • Joubu


Next meeting